chore: setup pact in CI/CD #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| //go:build smoke | |||
scripts/publish-contract.sh
Outdated
|
|
||
| if [[ $(git diff ..main **/pacts/*.json) ]]; then | ||
| echo "Contract has changed" | ||
| if [[ $(git diff ..main .consumer-version) ]]; then |
There was a problem hiding this comment.
Should we add that to the CI to forcibly fail PR checks?
There was a problem hiding this comment.
What do you mean? Do you mean an earlier linting check rather than failing so late in the CI/CD?
scripts/publish-contract.sh
Outdated
| else | ||
| echo "Publishing Pact contracts..." | ||
| pact-broker publish internal/deepcode/pacts/code-client-go-snykcodeapi.json --consumer-app-version "$consumerVersion" --branch main --broker-base-url "$brokerUrl" --broker-token "$brokerToken" | ||
| pact-broker publish internal/workspace/2024-03-12/pacts/code-client-go-workspaceapi.json --consumer-app-version "$consumerVersion" --branch main --broker-base-url "$brokerUrl" --broker-token "$brokerToken" |
There was a problem hiding this comment.
It'd be safer to pass broker token as env variable with PACT_BROKER_TOKEN instead of CLI parameter.
|
|
teodora-sandu
force-pushed
the
chore/pact-setup
branch
6 times, most recently
from
1a614d9
to
40cf21f
Compare
teodora-sandu
force-pushed
the
chore/pact-setup
branch
2 times, most recently
from
3dd6586
to
91757e1
Compare
teodora-sandu
force-pushed
the
chore/pact-setup
branch
from
91757e1
to
8769a25
Compare
|
Most of this was implemented in #55. This version is the diamond version but webhookless, which we shouldn't do because of what's explained in https://snyksec.atlassian.net/browse/IDE-296?focusedCommentId=998299. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagram of the pipeline can be found at https://miro.com/app/board/uXjVNsON77A=/?moveToWidget=3458764586699482727&cot=14
The
workspace-servicebranch is https://github.com/snyk/workspace-service/compare/main...feat/spike/pact-separate.After
publish-contract:After
verify-contract:After
make is-contract-compatible:workspace-servicehas not deployed the versionworkspace-servicehas deployed the version (../code-client-go/.bin/pact/bin/pact-broker record_deployment --pacticipant WorkspaceApi --version 7.35.1-featspikepact-separate+7.147b9763.SNAPSHOT.Teodoras-MacBook-Pro --environment production --broker-base-url $PACT_BROKER_URL --broker-token $PACT_BROKER_TOKENfrom theworkspace-servicerepo)We need to be able to create an environment first:
../code-client-go/.bin/pact/bin/pact-broker create-environment --name production --display-name Production --production --broker-base-url $PACT_BROKER_URL --broker-token $PACT_BROKER_TOKENAfter
make deploy-contract:To do:
workspace-servicetests inverify-contractworkspace-servicebranch once https://github.com/snyk/workspace-service/compare/main...feat/spike/pact-separate is PR-ed and mergedmake deploy-contractone