Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix label instance reuse bug during pruning #50

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

darscan
Copy link
Contributor

@darscan darscan commented Mar 6, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixes a label instance reuse bug during pruning.

Why is this a fixture update and not an explicit focused test?

  • It's an implementation bug that does not deserve negative testing

Why is this a fixture update and not an explicit focused test?

- It's an implementation bug that does not deserve negative testing
@darscan darscan requested a review from gablaxian March 6, 2020 12:25
@darscan darscan requested a review from a team as a code owner March 6, 2020 12:25
@darscan darscan self-assigned this Mar 6, 2020
Copy link
Contributor

@gjvis gjvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😹

@darscan darscan merged commit 24f0506 into master Mar 6, 2020
@darscan darscan deleted the fix/fix-label-pruning-bug branch March 6, 2020 13:02
@snyksec
Copy link

snyksec commented Mar 6, 2020

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants