Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop @snyk/lodash dependency, + bumps #63

Merged
merged 2 commits into from
May 24, 2020
Merged

Conversation

FauxFaux
Copy link
Contributor

What does this PR do?

Swap out @snyk/lodash for lodash.isequal, our only use.

Bump some stuff while we're here.

@FauxFaux FauxFaux requested a review from a team as a code owner May 24, 2020 11:10
@michael-go
Copy link
Contributor

prettier was intentionally at 1.x as 2.x fails on node 8

@FauxFaux
Copy link
Contributor Author

Some of the other projects are set up to lint only on 12, but test on 8.

@FauxFaux
Copy link
Contributor Author

Gee, I sure am glad that bug where we overcount node 8, so still support node 8, still exists.

@FauxFaux FauxFaux merged commit a906248 into master May 24, 2020
@FauxFaux FauxFaux deleted the feat/bumps-lodash branch May 24, 2020 15:23
@snyksec
Copy link

snyksec commented May 24, 2020

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants