feat: deduplicate cycles in graph #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darscan
reviewed
Dec 14, 2020
| depGraph.rootNodeId | ||
| ); | ||
|
|
||
| const eventLoopSpinner = new EventLoopSpinner(); |
There was a problem hiding this comment.
This can move to module scope - there's no value in passing a locally scoped instance around
darscan
reviewed
Dec 14, 2020
| }; | ||
| dependencies = []; | ||
| } else if (memoizationSet.has(nodeId)) { | ||
| dependencies = []; |
There was a problem hiding this comment.
Hmm.. this is a very obscure way to skip the iteration on line 65. It took a while for me to understand why you'd be setting this to an empty list.
admons
force-pushed
the
feat/deduplicate-cycles
branch
from
cb896d7
to
5f59060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
new
mapToNonCyclicGraphfunction that takes a cyclic depgraph and returns a new instance of a depGraph with the cycles pruned.