Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecate all legacy exports #88

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

robcresswell
Copy link
Contributor

I'm gradually removing all usage of the tree to graph conversions from our internal systems. We should begin to surface that these structures are being removed (via deprecation warnings) so there aren't new uses of trees being created

@robcresswell robcresswell requested a review from a team as a code owner June 24, 2021 11:28
@robcresswell robcresswell self-assigned this Jun 24, 2021
Copy link
Contributor

@darscan darscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@darscan
Copy link
Contributor

darscan commented Jun 24, 2021

Love it. Is it a feat though? fix maybe?

@robcresswell
Copy link
Contributor Author

I actually don't know, but "announcing" a bunch of deprecations as a patch release felt weird to me.

@darscan
Copy link
Contributor

darscan commented Jun 25, 2021

Deprecations are best announced early

@robcresswell
Copy link
Contributor Author

@darscan Yeah but how does that relate to patch Vs minor release?

I'm gradually removing all usage of the tree to graph conversions from
our internal systems. We should begin to surface that these structures
are being removed (via deprecation warnings) so there aren't new uses of
trees being created
@robcresswell robcresswell merged commit 30970c8 into master Jun 29, 2021
@robcresswell robcresswell deleted the feat/deprecate-legacy branch June 29, 2021 10:59
@robcresswell robcresswell changed the title feat: Deprecate all legacy exports fix: Deprecate all legacy exports Jun 29, 2021
@snyksec
Copy link

snyksec commented Jun 29, 2021

🎉 This PR is included in version 1.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants