Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds packages.config support for target framework parsing. #17

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

RyanHavoc
Copy link
Contributor

@RyanHavoc RyanHavoc commented Dec 19, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds packages.config support for targetFramework extraction.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/BST-265

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2018

CLA assistant check
All committers have signed the CLA.

@RyanHavoc RyanHavoc force-pushed the feat/adds-packages-config-support branch from b555f5c to 9994987 Compare December 19, 2018 17:09
lib/index.ts Outdated Show resolved Hide resolved
test/lib/target-frameworks.test.ts Show resolved Hide resolved
lib/parsers/index.ts Show resolved Hide resolved
@RyanHavoc RyanHavoc force-pushed the feat/adds-packages-config-support branch from 9994987 to 7b5f197 Compare December 20, 2018 09:32
lib/index.ts Outdated Show resolved Hide resolved
@RyanHavoc RyanHavoc force-pushed the feat/adds-packages-config-support branch from 7b5f197 to bb4adc3 Compare December 20, 2018 11:45
@RyanHavoc RyanHavoc force-pushed the feat/adds-packages-config-support branch from bb4adc3 to b927a73 Compare December 20, 2018 16:54
@lili2311
Copy link
Contributor

👏

@RyanHavoc RyanHavoc merged commit 7c310db into master Dec 20, 2018
@snyksec
Copy link

snyksec commented Dec 20, 2018

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants