Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource source when scanning IaC #873

Closed
eliecharra opened this issue Jul 23, 2021 · 2 comments · Fixed by #897
Closed

Add resource source when scanning IaC #873

eliecharra opened this issue Jul 23, 2021 · 2 comments · Fixed by #897
Assignees
Labels
kind/maintenance Refactoring or changes to the workspace priority/2

Comments

@eliecharra
Copy link
Contributor

Description
Be able to identify resources origin for resources coming from IaC. The final goal is to display resource source in the output.

Solution
We should create a new composed struct StateResource :

type ResourceSource struct {
	Module string
	Name   string
	State  string
}

type StateResource struct {
	AbstractResource
	Source ResourceSource
}

and when we read IaC code we should add Source to be able to track down the resource during the execution.

@sundowndev
Copy link
Contributor

sundowndev commented Jul 28, 2021

Following #877, may be we can add the state version as well, so in JSON and HTML output we'd have a list of iac sources and their version. WDYT @cloudskiff/engineering ?

type ResourceSource struct {
	Module string
	Name   string
	State  string
+	Version  string

@eliecharra eliecharra self-assigned this Jul 28, 2021
@eliecharra eliecharra moved this from Ready To Develop to In Progress in driftctl Jul 28, 2021
@eliecharra
Copy link
Contributor Author

eliecharra commented Jul 29, 2021

Following #877, may be we can add the state version as well, so in JSON and HTML output we'd have a list of iac sources and their version. WDYT @cloudskiff/engineering ?

type ResourceSource struct {
	Module string
	Name   string
	State  string
+	Version  string

Where does the #877 came from ? We didn't talked about it in technical meetings, and the issue descriptiojn is empty.
I can't say anything about it since I don't know what we want, maybe we should put it in Under Investigation ?

driftctl automation moved this from In Progress to Done Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace priority/2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants