Add resource source for terraform state #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eliecharra
commented
Jul 29, 2021
•
eliecharra
commented
| Q | A |
|---|---|
| π Bug fix? | no |
| π New feature? | no |
| β Deprecations? | no |
| β BC Break | no |
| π Related issues | Fix #873 |
| β Documentation | no |
Codecov Report
@@ Coverage Diff @@
## main #897 +/- ##
==========================================
- Coverage 81.66% 81.59% -0.07%
==========================================
Files 231 232 +1
Lines 7494 7520 +26
==========================================
+ Hits 6120 6136 +16
- Misses 1149 1159 +10
Partials 225 225
|
moadibfr
reviewed
Jul 30, 2021
wbeuil
reviewed
Jul 30, 2021
| for _, stateVal := range val { | ||
| res, err := r.deserializer.DeserializeOne(ty, stateVal.val) | ||
| if err != nil { | ||
| logrus.WithField("ty", ty).Warnf("Could not read from state: %+v", err) |
There was a problem hiding this comment.
Maybe we can display here in which state the error came from
There was a problem hiding this comment.
Yeah good idea, that was not the original goal of this PR but it can't hurt. Let's do this !
eliecharra
force-pushed
the
add_state_source_in_resources
branch
from
97ffad9
to
82b8c1c
Compare
moadibfr
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.