feat: add aws ecr_repository_policy resource
#1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almog27
force-pushed
the
feat/aws_ecr_repository_policy
branch
from
7364723
to
5ca79c0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
- Coverage 81.71% 81.71% -0.01%
==========================================
Files 439 440 +1
Lines 16023 16059 +36
==========================================
+ Hits 13093 13122 +29
- Misses 2613 2618 +5
- Partials 317 319 +2
|
sundowndev-snyk
suggested changes
May 11, 2022
|
@almog27 This one seems to be blocked in review for a couple of days, is there something blocking us there ? |
almog27
force-pushed
the
feat/aws_ecr_repository_policy
branch
7 times, most recently
from
771e368
to
dc392e0
Compare
moadibfr
suggested changes
Jun 3, 2022
There was a problem hiding this comment.
one of the error is incorrect but everything else LGTM. You could fix that and rebase so we can merge this pr.
Also, we should probably write a ticket to support deepmode for this one as policy support without policy content is not that useful (cc @sjourdan )
almog27
force-pushed
the
feat/aws_ecr_repository_policy
branch
2 times, most recently
from
046752c
to
48b668b
Compare
sundowndev-snyk
suggested changes
Jun 7, 2022
almog27
force-pushed
the
feat/aws_ecr_repository_policy
branch
4 times, most recently
from
7186dd0
to
ab64949
Compare
almog27
force-pushed
the
feat/aws_ecr_repository_policy
branch
from
ab64949
to
af8b0a3
Compare
almog27
force-pushed
the
feat/aws_ecr_repository_policy
branch
from
af8b0a3
to
7fdc7cf
Compare
moadibfr
approved these changes
Jun 8, 2022
sundowndev-snyk
approved these changes
Jun 8, 2022
This was referenced Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ecr_repository_policyresource as part of the AWS coverage