Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix issue tagging script #1531

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

sundowndev-snyk
Copy link
Contributor

@sundowndev-snyk sundowndev-snyk commented Jun 7, 2022

Description

This script was throwing an error when there's no issue to create a milestone for. This PR adds a check on the ISSUES array, if it's empty, don't rewrite the array. So it will create an empty milestone for this release.

Example of failure

@sundowndev-snyk sundowndev-snyk requested a review from a team as a code owner June 7, 2022 14:05
@sundowndev-snyk sundowndev-snyk requested review from wbeuil and removed request for a team June 7, 2022 14:05
karniwl
karniwl previously approved these changes Jun 7, 2022
Copy link
Contributor

@karniwl karniwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@codecov-commenter
Copy link

Codecov Report

Merging #1531 (0197053) into main (0aee331) will increase coverage by 6.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
+ Coverage   74.98%   81.69%   +6.71%     
==========================================
  Files         514      439      -75     
  Lines       19353    16023    -3330     
==========================================
- Hits        14511    13090    -1421     
+ Misses       4536     2615    -1921     
- Partials      306      318      +12     
Impacted Files Coverage Δ
pkg/terraform/plugin_client.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/remote/aws/client/s3_client_factory.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/remote/aws/init.go 0.00% <0.00%> (-94.79%) ⬇️
pkg/resource/azurerm/azurerm_image.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/azurerm/azurerm_resource_group.go 12.50% <0.00%> (-87.50%) ⬇️
pkg/resource/google/google_compute_address.go 14.28% <0.00%> (-85.72%) ⬇️
...g/resource/google/google_compute_global_address.go 14.28% <0.00%> (-85.72%) ⬇️
...ce/google/google_compute_instance_group_manager.go 14.28% <0.00%> (-85.72%) ⬇️
pkg/remote/azurerm/init.go 0.00% <0.00%> (-84.22%) ⬇️
pkg/resource/aws/aws_lb.go 16.66% <0.00%> (-83.34%) ⬇️
... and 176 more

@sundowndev-snyk sundowndev-snyk changed the title chore: exit script when there's no issue to tag chore: fix issue tagging script Jun 8, 2022
@eliecharra eliecharra merged commit a3f4156 into main Jun 8, 2022
@eliecharra eliecharra deleted the chore/fix-issue-tagging-script branch June 8, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants