fix: enumlib: remove a scan-specific error message #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since AWS is the default cloud provider for `driftctl scan`, we give users a hint on how to configure different providers with `--to` if there is an error authenticating with AWS - since they might not have even intended to use AWS in the first place. Now that this functionality is inside the enumeration library, with consumers other than `driftctl scan`, we remove this hint from the lower layer and re-add it for the scan command only, to avoid confusing non-driftctl users.
moadibfr
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since AWS is the default cloud provider for
driftctl scan, we giveusers a hint on how to configure different providers with
--toifthere is an error authenticating with AWS - since they might not have
even intended to use AWS in the first place.
Now that this functionality is inside the enumeration library, with
consumers other than
driftctl scan, we remove this hint from the lowerlayer and re-add it for the scan command only, to avoid confusing
non-driftctl users.