Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore arn attribute for some AWS resources #1578

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

sundowndev-snyk
Copy link
Contributor

@sundowndev-snyk sundowndev-snyk commented Aug 5, 2022

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1570
❓ Documentation no

Description

This PR ignore the arn attribute for those resources as it brings false positives :

  • aws_vpc
  • aws_internet_gateway
  • aws_launch_template
  • aws_instance

Related Jira issue: CTX-369

@sundowndev-snyk sundowndev-snyk requested a review from a team as a code owner August 5, 2022 12:49
@sundowndev-snyk sundowndev-snyk requested review from muratcelep and removed request for a team August 5, 2022 12:49
@sundowndev-snyk sundowndev-snyk requested review from eliecharra and removed request for muratcelep August 8, 2022 08:59
@eliecharra eliecharra merged commit cc6e2ca into main Aug 8, 2022
@eliecharra eliecharra deleted the fix/arn_diff_false_positive branch August 8, 2022 11:25
@eliecharra eliecharra added the kind/bug Something isn't working label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants