Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a diagnostic when enumerating unsuported types #1589

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

moadibfr
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

Description

add a diagnostic when enumerating unsuported types

@moadibfr moadibfr requested a review from a team as a code owner September 28, 2022 15:17
@moadibfr moadibfr requested review from chdorner-snyk and removed request for a team September 28, 2022 15:17
chdorner-snyk
chdorner-snyk previously approved these changes Sep 29, 2022
Copy link
Contributor

@chdorner-snyk chdorner-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍘

Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

@moadibfr moadibfr merged commit 9d35f9c into main Nov 8, 2022
@moadibfr moadibfr deleted the fea/filter_google_query branch November 8, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants