Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue - 1616 - run NewAwsNatGatewayEipAssoc after NewAwsNatGatewayEip… #1619

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Issue - 1616 - run NewAwsNatGatewayEipAssoc after NewAwsNatGatewayEip… #1619

merged 1 commit into from
Feb 7, 2023

Conversation

n2N8Z
Copy link
Contributor

@n2N8Z n2N8Z commented Feb 1, 2023

…Assoc, and remove eip associations from remoteResources and resourcesFromState

Q A
🐛 Bug fix? yes
🚀 New feature? no
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues #1616
❓ Documentation no

Description

run NewAwsNatGatewayEipAssoc after NewAwsNatGatewayEipAssoc, and remove eip associations from remoteResources and resourcesFromState

@n2N8Z n2N8Z requested a review from a team as a code owner February 1, 2023 14:31
@n2N8Z n2N8Z requested review from eliecharra and removed request for a team February 1, 2023 14:31
@CLAassistant
Copy link

CLAassistant commented Feb 1, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@n2N8Z
Issue - 1616 - run NewAwsNatGatewayEipAssoc after NewAwsNatGatewayEip…
fe5d419 
…Assoc, and remove eip associations from remoteResources and resourcesFromState
@n2N8Z n2N8Z mentioned this pull request Feb 1, 2023
Closed
@moadibfr
Copy link
Contributor

moadibfr commented Feb 6, 2023

hey @n2N8Z 👋
Thanks a lot for you contribution ! 🙏
This looks good and should fix the issue you discovered. We need you to sign the cla to be able to merge you contribution.
Also I was thinking maybe adding a test case could have been good

@n2N8Z
Copy link
Contributor Author

n2N8Z commented Feb 6, 2023

Re the CLA, the CLAassistant message says:

You have signed the CLA already but the status is still pending? Let us recheck it.

What else do I need to do ?

@moadibfr
Copy link
Contributor

moadibfr commented Feb 6, 2023

Re the CLA, the CLAassistant message says:

You have signed the CLA already but the status is still pending? Let us recheck it.

What else do I need to do ?

can you click on the icon above that says "not signed yet"

@n2N8Z
Copy link
Contributor Author

n2N8Z commented Feb 6, 2023

Done. Now it's happy.

moadibfr
moadibfr approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@moadibfr moadibfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution 🙏

@moadibfr moadibfr merged commit 9634c72 into snyk:main Feb 7, 2023
@moadibfr
Copy link
Contributor

moadibfr commented Feb 7, 2023

@all-contributors please add @n2N8Z for bug

@allcontributors allcontributors bot mentioned this pull request Feb 7, 2023
Merged
@allcontributors
Copy link
Contributor

@moadibfr

I've put up a pull request to add @n2N8Z! 🎉

@QJoly QJoly mentioned this pull request Jun 8, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadibfr moadibfr moadibfr approved these changes

@eliecharra eliecharra Awaiting requested review from eliecharra eliecharra was automatically assigned from snyk/cloud-context

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@n2N8Z @CLAassistant @moadibfr