Sort unmanaged & deleted resources in a predictable order #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 69.44% 69.48% +0.04%
==========================================
Files 281 281
Lines 6016 6024 +8
==========================================
+ Hits 4178 4186 +8
Misses 1486 1486
Partials 352 352
|
moadibfr
suggested changes
Mar 22, 2021
sundowndev
changed the title
eliecharra
approved these changes
Mar 23, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, resources were fetched in parallel which would cause the resource list order to be unpredictable. With these changes, the resources are always sorted by their Terraform Id.