Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to filter on Cty.Value #363

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Refactoring to filter on Cty.Value #363

merged 1 commit into from
Mar 29, 2021

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Mar 23, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? yes
❌ BC Break yes
πŸ”— Related issues none
❓ Documentation yes

Description

First step into our new way to remove our deserializers and be able to scan/read state from old terraform-provider-aws version.

  • Created a new attribute CtyVal to encapsulate the cty.value of each resource
  • Filtered on cty.value and not on the custom struct anymore
  • Fixed tests

@wbeuil wbeuil force-pushed the new-archi/filtering branch 2 times, most recently from c2cd679 to 7af61ca Compare March 25, 2021 11:14
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #363 (0881b44) into main (e238772) will decrease coverage by 0.29%.
The diff coverage is 53.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   69.48%   69.19%   -0.30%     
==========================================
  Files         281      281              
  Lines        6024     6149     +125     
==========================================
+ Hits         4186     4255      +69     
- Misses       1486     1542      +56     
  Partials      352      352              
Impacted Files Coverage Ξ”
pkg/resource/aws/aws_ami.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_cloudfront_distribution.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_db_instance.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_db_subnet_group.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_default_route_table.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_default_security_group.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_default_subnet.go 66.66% <0.00%> (+16.66%) ⬆️
pkg/resource/aws/aws_default_vpc.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_dynamodb_table.go 66.66% <0.00%> (-33.34%) ⬇️
pkg/resource/aws/aws_ebs_snapshot.go 66.66% <0.00%> (-33.34%) ⬇️
... and 108 more

@wbeuil wbeuil marked this pull request as ready for review March 25, 2021 13:19
@wbeuil wbeuil requested a review from a team as a code owner March 25, 2021 13:19
Copy link
Contributor

@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test files appear to contain few unwanted lines

sundowndev
sundowndev previously approved these changes Mar 25, 2021
pkg/filter/filter_engine_test.go Outdated Show resolved Hide resolved
pkg/filter/filter_engine_test.go Outdated Show resolved Hide resolved
@eliecharra eliecharra merged commit 42e4342 into main Mar 29, 2021
@eliecharra eliecharra deleted the new-archi/filtering branch March 29, 2021 09:14
@eliecharra eliecharra linked an issue Mar 29, 2021 that may be closed by this pull request
@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform AWS Provider v2 support
4 participants