Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start testing middlewares that create resources #411

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Start testing middlewares that create resources #411

merged 2 commits into from
Apr 8, 2021

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Apr 7, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues none
❓ Documentation no

Description

Testing middlewares that create new resources with a CtyVal attribute.

@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited

Codecov Report

Merging #411 (8e56de6) into main (d9a8298) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   70.25%   70.48%   +0.22%     
==========================================
  Files         282      282              
  Lines        6284     6284              
==========================================
+ Hits         4415     4429      +14     
+ Misses       1504     1490      -14     
  Partials      365      365
Impacted Files Coverage Ξ”
pkg/analyser/analyzer.go 94.73% <0.00%> (+2.63%) ⬆️
pkg/middlewares/aws_default_igw_route.go 100.00% <0.00%> (+3.70%) ⬆️
pkg/resource/aws/aws_route.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_instance.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_s3_bucket.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_sns_topic.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_sqs_queue.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_ebs_volume.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_route_table.go 100.00% <0.00%> (+33.33%) ⬆️
pkg/resource/aws/aws_s3_bucket_policy.go 100.00% <0.00%> (+33.33%) ⬆️
... and 3 more

@wbeuil wbeuil marked this pull request as ready for review April 8, 2021 09:58
@wbeuil wbeuil requested a review from a team as a code owner April 8, 2021 09:58
eliecharra
eliecharra approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, impressive 😲

@eliecharra eliecharra merged commit 90da652 into main Apr 8, 2021
@eliecharra eliecharra deleted the test/middlewares branch April 8, 2021 16:15
@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Apr 8, 2021
@eliecharra eliecharra added this to Review in driftctl via automation Apr 8, 2021
@eliecharra eliecharra added this to the v0.8.0 milestone Apr 8, 2021
@eliecharra eliecharra linked an issue Apr 8, 2021 that may be closed by this pull request
Terraform AWS Provider v2 support #347
Closed
@eliecharra eliecharra moved this from Review to Done in driftctl Apr 12, 2021
@sundowndev sundowndev mentioned this pull request Apr 30, 2021
Closed
@sundowndev sundowndev mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
No open projects
driftctl
Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Terraform AWS Provider v2 support
2 participants
@wbeuil @eliecharra