Publish driftctl to Arch user repository #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 284 284
Lines 6396 6396
=======================================
Hits 4524 4524
Misses 1504 1504
Partials 368 368 |
wbeuil
suggested changes
Apr 9, 2021
README.md
Outdated
| <br> | ||
| <a href="https://repology.org/project/driftctl/versions"> | ||
| <img src="https://repology.org/badge/vertical-allrepos/driftctl.svg" alt="Packaging status"> | ||
| </a> |
There was a problem hiding this comment.
I'm not huge fan of having something that big as a badge. We can use their tiny badges as per the docs of repology if we really want to display actual version for each package manager.
There was a problem hiding this comment.
And what about something like this ?
Packaging status
There was a problem hiding this comment.
Didn't know we could do that in markdown ! I'm ok with that
README.md
Outdated
| @@ -6,7 +6,7 @@ | |||
| <img src="https://circleci.com/gh/cloudskiff/driftctl.svg?style=shield"/> | |||
| <img src="https://goreportcard.com/badge/github.com/cloudskiff/driftctl"/> | |||
| <img src="https://img.shields.io/github/license/cloudskiff/driftctl"> | |||
| <img src="https://img.shields.io/github/v/release/cloudskiff/driftctl"> | |||
| <img src="https://img.shields.io/github/v/release/cloudskiff/driftctl?label=latest%20version"> | |||
There was a problem hiding this comment.
Why the change of label ? The word release is enough self-explanatory.
There was a problem hiding this comment.
Yeah I think it was unclear with the new block label, will revert this with the usage of individual labels
eliecharra
force-pushed
the
publish-to-aur
branch
4 times, most recently
from
fbf7fe0
to
d59e6b2
Compare
eliecharra
force-pushed
the
publish-to-aur
branch
from
d59e6b2
to
3e9cf74
Compare
wbeuil
approved these changes
Apr 14, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add automatic publish to arch user repository.
Example pipeline can be found there : https://app.circleci.com/pipelines/github/cloudskiff/driftctl/1171/workflows/672dbdd4-d2cb-4ad1-aefe-4af1559288e4/jobs/1845