Resume progress bar after timeout #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 69.71% 69.72% +0.01%
==========================================
Files 286 286
Lines 6590 6593 +3
==========================================
+ Hits 4594 4597 +3
Misses 1625 1625
Partials 371 371
|
sundowndev
force-pushed
the
fix/progressBarResume
branch
from
4887f5d
to
dd31f23
Compare
wbeuil
previously approved these changes
Apr 20, 2021
sundowndev
force-pushed
the
fix/progressBarResume
branch
from
dd31f23
to
7c4f1a7
Compare
wbeuil
previously approved these changes
Apr 20, 2021
sundowndev
force-pushed
the
fix/progressBarResume
branch
from
7c4f1a7
to
b38063d
Compare
|
@wbeuil just rebased this one, can you review again so I can merge it? thanks |
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The progress bar should be restarted automatically after a timeout if a new event occur. Sometime read actions may be slow but ends with a success after the timeout, for me we should show that something hang bit if it's ends with a success we should resume the spinning.