Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check codecov shasum before uploading test coverage #451

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

wbeuil
Copy link
Contributor

@wbeuil wbeuil commented Apr 20, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues none
❓ Documentation no

Description

Due to the recent Codecov breach, we should check the shasum of the bash uploader before using it.

@wbeuil wbeuil requested a review from a team as a code owner April 20, 2021 08:45
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #451 (94e5e15) into main (5ff2946) will not change coverage.
The diff coverage is n/a.

❗ Current head 94e5e15 differs from pull request most recent head ab7fac1. Consider uploading reports for the commit ab7fac1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files         284      284           
  Lines        6396     6396           
=======================================
  Hits         4524     4524           
  Misses       1504     1504           
  Partials      368      368           
Impacted Files Coverage Ξ”
pkg/driftctl.go 68.05% <0.00%> (ΓΈ)

.circleci/config.yml Outdated Show resolved Hide resolved
eliecharra
eliecharra previously approved these changes Apr 20, 2021
@eliecharra eliecharra merged commit 4b97d96 into main Apr 20, 2021
@eliecharra eliecharra deleted the fix/codecov branch April 20, 2021 09:05
@sundowndev sundowndev added the kind/maintenance Refactoring or changes to the workspace label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants