Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new progress bar for state enumeration #460

Merged
merged 3 commits into from
May 4, 2021

Conversation

sundowndev
Copy link
Contributor

@sundowndev sundowndev commented Apr 26, 2021

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #408
❓ Documentation no

Description

Listing states from S3 can take time and make the progressbar timeout. We should introduce a new progressbar for state enumeration count and one for resource enumeration from states files.

This change updates the actual progress interface and introduce a new progress bar for state enumeration.

@sundowndev sundowndev added kind/bug Something isn't working priority/2 labels Apr 26, 2021
@sundowndev sundowndev added this to the v0.8.0 milestone Apr 26, 2021
@sundowndev sundowndev self-assigned this Apr 26, 2021
@sundowndev sundowndev added this to Review in driftctl via automation Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #460 (85929f8) into v0.8 (b64276a) will increase coverage by 0.03%.
The diff coverage is 68.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.8     #460      +/-   ##
==========================================
+ Coverage   70.73%   70.76%   +0.03%     
==========================================
  Files         287      287              
  Lines        6472     6496      +24     
==========================================
+ Hits         4578     4597      +19     
- Misses       1521     1522       +1     
- Partials      373      377       +4     
Impacted Files Coverage Ξ”
pkg/cmd/scan.go 82.47% <0.00%> (+0.35%) ⬆️
pkg/output/progress.go 86.20% <71.42%> (-8.80%) ⬇️
pkg/driftctl.go 71.25% <100.00%> (+2.33%) ⬆️
pkg/iac/supplier/supplier.go 85.18% <100.00%> (ΓΈ)
pkg/iac/terraform/state/terraform_state_reader.go 68.49% <100.00%> (+0.21%) ⬆️

@sundowndev sundowndev changed the title Make the progress bar global Introduce a new progress bar for state enumeration Apr 27, 2021
@sundowndev sundowndev marked this pull request as ready for review April 27, 2021 14:20
@sundowndev sundowndev requested a review from a team as a code owner April 27, 2021 14:20
@sundowndev sundowndev changed the base branch from main to v0.8 April 28, 2021 11:17
pkg/cmd/scan.go Outdated Show resolved Hide resolved
pkg/output/progress.go Outdated Show resolved Hide resolved
pkg/driftctl.go Show resolved Hide resolved
pkg/iac/supplier/supplier.go Outdated Show resolved Hide resolved
@sundowndev sundowndev requested a review from moadibfr May 4, 2021 13:27
@sundowndev sundowndev merged commit 5e1f9f8 into v0.8 May 4, 2021
@sundowndev sundowndev deleted the feat/s3EnumProgress branch May 4, 2021 14:20
driftctl automation moved this from Review to Done May 4, 2021
This was referenced May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/2
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants