Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry #465

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Add telemetry #465

merged 2 commits into from
Apr 28, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #441
❓ Documentation yes

Description

Add driftctl telemetry data

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Apr 27, 2021
@eliecharra eliecharra requested a review from a team April 27, 2021 16:34
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #465 (777ee1e) into v0.8 (ded5813) will decrease coverage by 0.01%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.8     #465      +/-   ##
==========================================
- Coverage   70.74%   70.72%   -0.02%     
==========================================
  Files         285      286       +1     
  Lines        6417     6440      +23     
==========================================
+ Hits         4540     4555      +15     
- Misses       1508     1514       +6     
- Partials      369      371       +2     
Impacted Files Coverage Ξ”
pkg/driftctl.go 68.05% <ΓΈ> (ΓΈ)
pkg/cmd/scan.go 81.65% <33.33%> (-0.65%) ⬇️
pkg/telemetry/telemetry.go 68.42% <68.42%> (ΓΈ)
pkg/cmd/driftctl.go 80.00% <100.00%> (+0.40%) ⬆️

@eliecharra eliecharra marked this pull request as ready for review April 28, 2021 08:25
@eliecharra eliecharra added this to the v0.8.0 milestone Apr 28, 2021
Copy link
Contributor

@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliecharra eliecharra merged commit 784bfc8 into v0.8 Apr 28, 2021
@eliecharra eliecharra deleted the add_telemetry branch April 28, 2021 15:53
This was referenced May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants