Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry duration #467

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Telemetry duration #467

merged 2 commits into from
Apr 30, 2021

Conversation

eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #442
❓ Documentation yes

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Apr 28, 2021
@eliecharra eliecharra added this to the v0.8.0 milestone Apr 28, 2021
@eliecharra eliecharra requested a review from a team April 28, 2021 10:43
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #467 (8b1b39f) into v0.8 (ea749fe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.8     #467      +/-   ##
==========================================
+ Coverage   70.72%   70.73%   +0.01%     
==========================================
  Files         286      286              
  Lines        6442     6445       +3     
==========================================
+ Hits         4556     4559       +3     
  Misses       1516     1516              
  Partials      370      370              
Impacted Files Coverage Ξ”
pkg/analyser/analysis.go 97.40% <ΓΈ> (ΓΈ)
pkg/driftctl.go 68.91% <100.00%> (+0.86%) ⬆️
pkg/telemetry/telemetry.go 70.00% <100.00%> (+1.57%) ⬆️

@eliecharra eliecharra marked this pull request as ready for review April 28, 2021 15:54
@eliecharra eliecharra merged commit 2ef6593 into v0.8 Apr 30, 2021
@eliecharra eliecharra deleted the telemetry_duration branch April 30, 2021 14:24
This was referenced May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants