Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws_iam_policy_attachment resources from strict mode #498

Merged
merged 1 commit into from
May 10, 2021

Conversation

sundowndev
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #489
❓ Documentation yes

Description

Manually adding an IAM policy on an IAM user was detected as a drift until 0.7.0 but 0.7.1 did not (regression)

@sundowndev sundowndev added this to the v0.8.0 milestone May 7, 2021
@sundowndev sundowndev self-assigned this May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #498 (c76702b) into v0.8 (717ffae) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.8     #498      +/-   ##
==========================================
- Coverage   70.96%   70.90%   -0.07%     
==========================================
  Files         289      289              
  Lines        6562     6548      -14     
==========================================
- Hits         4657     4643      -14     
  Misses       1525     1525              
  Partials      380      380              
Impacted Files Coverage Ξ”
pkg/middlewares/aws_defaults.go 100.00% <ΓΈ> (ΓΈ)

@sundowndev sundowndev changed the title Detect aws_iam_policy_attachment resources even for default IAM roles Remove aws_iam_policy_attachment resources from strict mode May 10, 2021
@sundowndev sundowndev marked this pull request as ready for review May 10, 2021 08:18
@sundowndev sundowndev requested a review from a team as a code owner May 10, 2021 08:18
@sundowndev sundowndev added this to Review in driftctl May 10, 2021
@eliecharra eliecharra merged commit bba8627 into v0.8 May 10, 2021
@eliecharra eliecharra deleted the fix/defaultPolicyAttachments branch May 10, 2021 08:22
This was referenced May 10, 2021
@sundowndev sundowndev moved this from Review to Done in driftctl May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants