Include resource ID in scanning errors to ignore a particular resource

[sundowndev]

Q	A
🐛 Bug fix?	yes
🚀 New feature?	no
⚠ Deprecations?	no
❌ BC Break	no
🔗 Related issues	#666
❓ Documentation	no

Description

When we encounter a Access Denied error on a particular resource, it creates an alert and ignore all resources of the same type. With this fix, we create an alert including the resource type & ID so we can only ignore that one.

What changed

• Moved RemoteAccessDeniedAlert into new pkg/remote/alerts package
• Moved RemoteAWSTerraform & RemoteGithubTerraform into pkg/remote/common/providers.go
• Deleted SupplierError and moved its methods into ResourceScanningError
• Added fields resourceType & resourceName in ResourceScanningError
• Added few unit tests to avoid regression and increase coverage

[codecov]

Codecov Report

Merging #905 (4e3d352) into main (62e0efe) will increase coverage by 0.03%.
The diff coverage is 72.16%.

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   81.66%   81.70%   +0.03%     
==========================================
  Files         232      233       +1     
  Lines        7566     7588      +22     
==========================================
+ Hits         6179     6200      +21     
- Misses       1159     1161       +2     
+ Partials      228      227       -1     

Impacted Files	Coverage Δ
pkg/remote/aws/dynamodb_table_details_fetcher.go	77.77% <0.00%> (ø)
...ote/aws/ec2_default_route_table_details_fetcher.go	77.77% <0.00%> (ø)
pkg/remote/aws/ec2_route_details_fetcher.go	81.81% <0.00%> (ø)
...aws/ec2_route_table_association_details_fetcher.go	77.77% <0.00%> (ø)
pkg/remote/aws/iam_access_key_details_fetcher.go	77.77% <0.00%> (ø)
pkg/remote/aws/iam_role_enumerator.go	92.85% <0.00%> (ø)
.../aws/iam_role_policy_attachment_details_fetcher.go	78.94% <0.00%> (ø)
.../aws/iam_user_policy_attachment_details_fetcher.go	78.94% <0.00%> (ø)
pkg/remote/aws/init.go	0.00% <0.00%> (ø)
...kg/remote/aws/s3_bucket_analytic_detail_fetcher.go	77.77% <0.00%> (ø)
... and 75 more

[wbeuil]

Small changes to make

[wbeuil]

Nice work !