feat: remove reset() #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: target node 8 (async)
BREAKING CHANGE: reset() is gone. Just don't use it. It is not really safe to use reset() ever. This library is shared between different bits of code. You cannot know if they might need to yield, even if you didn't. It's unclear it's even useful in other cases; much of the cost of using the library is in checking, not actually spinning.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: reset() is gone. Just don't use it.
It is not really safe to use reset() ever. This library is
shared between different bits of code. You cannot know if
they might need to yield, even if you didn't.
It's unclear it's even useful in other cases; much of the cost
of using the library is in checking, not actually spinning.
(Alternative: retain reset(), but make it do nothing?)
Also, while we're BREAKING: target node 8, which should get us better code (no
tslib_1.__awaiter).