-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add envvar AZURE_CLIENT_ID option #1326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the docs here too with how to set this up and why 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: you can squash all 6 commits into one commit, and give it a meaningful prefix before the commit message
https://www.notion.so/snyk/NOT-ARCHIVE-Git-Work-Methodologies-be6d298d764d47ca998d8f84991f4344?pvs=4#f2af5841f22446f28b3c27aec7a53642
eg, fix: add envvar AZURE_CLIENT_ID option
86ebef9
to
41d3a12
Compare
41d3a12
to
8d0d282
Compare
8d0d282
to
3422ff8
Compare
🎉 This PR is included in version 2.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Add envvar AZURE_CLIENT_ID that allows specifying a managed identity to be used when pulling images for scanning.
What this does
Updated Helm chart to add AZURE_CLIENT_ID envvar to
snyk-monitor
container, when needed (not empty string). The envvar is needed to avoid conflicting managed identities that allow thesnyk-monitor
to pull images from the container registry, therefore explicitly saying which of the identities to be used (by specifying its Client ID).Notes for the reviewer
Will update documentation about setting up
kubernetes-monitor
in Azure.Screenshots
N/A