fix: add envvar AZURE_CLIENT_ID option #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kat1906
approved these changes
Jun 22, 2023
minsiyang
reviewed
Jun 22, 2023
minsiyang
reviewed
Jun 22, 2023
minsiyang
reviewed
Jun 22, 2023
minsiyang
reviewed
Jun 22, 2023
minsiyang
approved these changes
Jun 22, 2023
ivanstanev
approved these changes
Jun 22, 2023
popas90
changed the title
minsiyang
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Nit: you can squash all 6 commits into one commit, and give it a meaningful prefix before the commit message
https://www.notion.so/snyk/NOT-ARCHIVE-Git-Work-Methodologies-be6d298d764d47ca998d8f84991f4344?pvs=4#f2af5841f22446f28b3c27aec7a53642
eg, fix: add envvar AZURE_CLIENT_ID option
popas90
force-pushed
the
popas90/azure-client-id-in-helm
branch
from
86ebef9
to
41d3a12
Compare
popas90
force-pushed
the
popas90/azure-client-id-in-helm
branch
from
41d3a12
to
8d0d282
Compare
popas90
force-pushed
the
popas90/azure-client-id-in-helm
branch
from
8d0d282
to
3422ff8
Compare
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add envvar AZURE_CLIENT_ID that allows specifying a managed identity to be used when pulling images for scanning.
What this does
Updated Helm chart to add AZURE_CLIENT_ID envvar to
snyk-monitorcontainer, when needed (not empty string). The envvar is needed to avoid conflicting managed identities that allow thesnyk-monitorto pull images from the container registry, therefore explicitly saying which of the identities to be used (by specifying its Client ID).Notes for the reviewer
Will update documentation about setting up
kubernetes-monitorin Azure.Screenshots
N/A