Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow OIDC authentication via Azure Workload Identity #1295

Merged
merged 1 commit into from
Apr 11, 2023
Merged

feat: allow OIDC authentication via Azure Workload Identity #1295

merged 1 commit into from
Apr 11, 2023

Conversation

kat1906
Copy link
Contributor

@kat1906 kat1906 commented Apr 11, 2023 •
edited
Loading

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

Upgrade docker-credential-acr-env to allow OIDC authentication via Azure Workload Identity.

Resolves #1223

Closes this PR: #1283

@kat1906
feat: allow OIDC authentication via Azure Workload Identity
929e265 
by upgrading docker-credentials-acr-env
@kat1906 kat1906 requested a review from a team as a code owner April 11, 2023 10:53
@github-actions
Copy link

github-actions bot commented Apr 11, 2023 •
edited by kat1906
Loading

Expected release notes (by @kat1906)

features:
allow OIDC authentication via Azure Workload Identity (929e265)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

jonnyowenpowell
jonnyowenpowell approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@jonnyowenpowell jonnyowenpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kat1906 kat1906 merged commit 45ecbd2 into staging Apr 11, 2023
@kat1906 kat1906 deleted the chore/upgrade-docker-credential-acr-env branch April 11, 2023 12:03
@kat1906 kat1906 mentioned this pull request Apr 11, 2023
Closed
@snyk-deployer
Copy link
Collaborator

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnyowenpowell jonnyowenpowell jonnyowenpowell approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🙏] Support for ACR authentication via Azure Workload Identity
3 participants
@kat1906 @snyk-deployer @jonnyowenpowell