feat: build acr cred helper binary from source [OI-183] #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popas90
reviewed
Apr 23, 2024
popas90
approved these changes
Apr 23, 2024
armand-snyk
changed the title
armand-snyk
force-pushed
the
feat/build-ecr-cred-helper-dockerfile
branch
from
5d38b34
to
2c05b8a
Compare
|
🎉 This PR is included in version 2.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This PR aims to remove a high vuln in the ubi9 docker image introduced through the docker-credential-acr-env package that we install.
The
docker-credential-acr-envrepository is not maintained and does not make any new releases, even though a fix for this vuln has been merged into the repo. The solution implemented in this PR creates another step in the ubi9 Dockerfile where the binary is built from source usinggo installpointed at the latest commit (as of writing this).Jira ticket OI-183