This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
fix: de/normalise all file separators in a string #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shesekino
force-pushed
the
chore/update_func_snapshot
branch
from
66b3e70
to
21124fa
Compare
according to their docs (https://www.appveyor.com/docs/how-to/repository-shallow-clone/) "If both clone_depth and shallow_clone exist in the config, clone_depth is ignored." we're apparently mentioning both, so clone_depth is ignored - might as well remove it.
- copied the latest published snapshot - adjusted tests as apparently there's another vulnerable package we're using in our tests
Shesekino
force-pushed
the
chore/update_func_snapshot
branch
from
05c4cc9
to
8129211
Compare
currently our tests fail on Windows because we neglect to normalise/denormalise all path separators. when interacting with the local filesystem, we need to make sure to use the native separator (slash on linux, backslash on windows). our normalising function used `string.prototype.replace(str, str)` which replaces only the first occurrence in a string. this commit fixes it to the `string.prototype.replace(regex, str)` signature which, coupled with a global regex, replaces all occurences. this commit isn't accompanied with a test since an existing test is already broken, and that test passing will be the proof of correctness.
Shesekino
changed the title
|
🎉 This PR is included in version 1.45.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?