Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: newer event-loop-spinner and node 8 #51

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

FauxFaux
Copy link
Contributor

@FauxFaux FauxFaux commented Jun 3, 2020

What this does

The new event-loop-spinner can better share its state with other libraries, reducing the waits for everyone.

BREAKING CHANGE: will no longer work on node 6
This was already set in the engines field, and in .nvmrc, and CI, so is probably not too controversial.
As we have performance sensitive code which is async, it's probably (untested) better to let the compiler take advantage of the platform we actually support.

The new event-loop-spinner can better share its state with
other libraries, reducing the waits for everyone.
BREAKING CHANGE: will no longer work on node 6

This was already set in the `engines` field, and in
`.nvmrc`, and CI, so is probably not too controversial.

As we have performance sensitive code which is async,
it's probably (untested) better to let the compiler
take advantage of the platform we actually support.
@FauxFaux FauxFaux requested a review from a team as a code owner June 3, 2020 15:26
@snyk-deployer
Copy link

Expected release notes (by @FauxFaux)

features:
target node 8, better code generation (4bc8f40)
upgrade event-loop-spinner, reducing waits (1b07555)

@ivanstanev ivanstanev self-assigned this Jun 4, 2020
Copy link
Contributor

@ivanstanev ivanstanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with docker-plugin and the CLI

@ivanstanev ivanstanev merged commit c9d36e5 into master Jun 8, 2020
@ivanstanev ivanstanev deleted the feat/event-loop branch June 8, 2020 11:39
@snyksec
Copy link

snyksec commented Jun 8, 2020

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants