Feat/return packages list #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface will be used to build a list of packages returned by the parser, but the comment currently is misleading.
Packages up until now were returned as a single string with each new line containing the package data. Readers of this output had to do further processing to extract the relevant package data. This single-string format was added to the plugin in order to match what the snyk-docker-plugin was expecting; it was used for backwards-compatibility. Now in addition to this we return the list of packages in a new field in the parser response so it is easier to process them. Additionally changed the following: - exceptions thrown by parsing the RPM package entries are no longer ignored - exceptions are now allowed to throw to the caller of the parser - improved docs around some types
Interfaces can be inferred by the IDE and don't need an "I" prefix in the name.
|
Expected release notes (by @ivanstanev) features: others (will not be included in Semantic-Release notes): |
|
Amazing improvements!! 🥇😄 So we still need the string |
agatakrajewska
approved these changes
Oct 13, 2020
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Packages up until now were returned as a single string with each new line containing the package data.
Readers of this output had to do further processing to extract the relevant package data.
This single-string format was added to the plugin in order to match what the snyk-docker-plugin was expecting; it was used for backwards-compatibility.
Now in addition to this we return the list of packages in a new field in the parser response so it is easier to process them.
Additionally changed the following:
Notes for the reviewer
Other various improvement added as separate commits 🙏