New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript types #34
Comments
We're a typescript company. We're more likely to rewrite the whole thing in Typescript. 😄 |
I did that without looking at your types. I think we should expose the Maybe* types, instead of just string. I don't think we can expose that Comparison type, the function probably does take strings in the real world. I didn't type up the internals. Do you care? |
Thanks for this! Agree with the Maybe types. Exposing the I would like the internals, if it's not too much trouble. They seem pretty straightforward from my typing of them. |
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you! |
I currently have a PR open, DefinitelyTyped/DefinitelyTyped#45824, to add types for
@snyk/ruby-semver
. However, it would be nice if these could be maintained and shipped with the actual package, instead of under@types/snyk__ruby-semver
.I'm still hoping to get some feedback from the DefinitelyTyped maintainers on my implementation, but are you open to the idea?
The text was updated successfully, but these errors were encountered: