-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port to typescript #35
Conversation
BREAKING CHANGE: changes exported types, so might break existing typescript code
"outDir": "./dist", | ||
"target": "es2017", | ||
"lib": [ | ||
"es2017" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our lib template https://github.com/snyk/typescript-library uses es2018 - any reason not to do that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is CLI, so node 8. https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-8 . Your link is private, not CLI.
"eslint": "^6.8.0", | ||
"eslint-config-prettier": "^6.11.0", | ||
"prettier": "^2.0.5", | ||
"typescript": "~3.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not use latest? 3.9.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript do not follow semver, and we have an issue with 3.9 in other libraries around microsoft/TypeScript#38568 . Probably doesn't matter here, but.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #34.
Nothing outrageous here. Compiler isn't apocalyptically angry about anything.. unless you turn
strict
on, then it is.