feat: port to typescript #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: changes exported types, so might break existing typescript code
ghost
requested review from
gitphill
reviewed
Jul 2, 2020
| "outDir": "./dist", | ||
| "target": "es2017", | ||
| "lib": [ | ||
| "es2017" |
There was a problem hiding this comment.
our lib template https://github.com/snyk/typescript-library uses es2018 - any reason not to do that here?
There was a problem hiding this comment.
This is CLI, so node 8. https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-8 . Your link is private, not CLI.
gitphill
reviewed
Jul 2, 2020
| "eslint": "^6.8.0", | ||
| "eslint-config-prettier": "^6.11.0", | ||
| "prettier": "^2.0.5", | ||
| "typescript": "~3.8.3" |
There was a problem hiding this comment.
Typescript do not follow semver, and we have an issue with 3.9 in other libraries around microsoft/TypeScript#38568 . Probably doesn't matter here, but.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Nothing outrageous here. Compiler isn't apocalyptically angry about anything.. unless you turn
stricton, then it is.