Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decouple os release analyzer #109

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

ivanstanev
Copy link
Contributor

@ivanstanev ivanstanev commented Sep 27, 2019

Allow the logic about processing OS release files to be reused in the future for static analysis.

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Allow the logic about processing OS release files to be reused in the future for static analysis.

What are the relevant tickets?

Jira ticket RUN-461

@ivanstanev ivanstanev requested a review from a team as a code owner September 27, 2019 13:41
@ivanstanev ivanstanev self-assigned this Sep 27, 2019
@ghost ghost removed their request for review September 27, 2019 13:41
@ivanstanev ivanstanev force-pushed the fix/decouple-os-release-analyzer branch from 8d89eae to f3b2f8f Compare September 27, 2019 13:54
@ivanstanev ivanstanev force-pushed the fix/decouple-analyzers branch 3 times, most recently from 77cc377 to e67c751 Compare October 2, 2019 11:00
@ivanstanev ivanstanev force-pushed the fix/decouple-os-release-analyzer branch 2 times, most recently from 0e7fa0a to 70c8fbc Compare October 2, 2019 16:22
Allow the logic about processing OS release files to be reused in the future for static analysis.
@ivanstanev ivanstanev force-pushed the fix/decouple-os-release-analyzer branch from 70c8fbc to 7a87cc9 Compare October 3, 2019 09:38
@ivanstanev ivanstanev changed the base branch from fix/decouple-analyzers to master October 3, 2019 09:38
Copy link

@talik077 talik077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Contributor

@hisenb3rg hisenb3rg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivanstanev ivanstanev merged commit 4728732 into master Oct 3, 2019
@snyksec
Copy link

snyksec commented Oct 3, 2019

🎉 This PR is included in version 1.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@team-lumos
Copy link
Collaborator

🎉 This issue has been resolved in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants