Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/code cleanup #283

Merged
merged 4 commits into from
Oct 19, 2020
Merged

fix/code cleanup #283

merged 4 commits into from
Oct 19, 2020

Conversation

ivanstanev
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Various clean ups:

  • Remove unused error handling in static scanning
  • Remove unused ls-utils.ts file
  • Reorganize dockerfile analysis to own module
  • Add more deprecation warnings around dependency tree use

@ivanstanev
fix: remove unused error handling in static scanning
975ed81
@ivanstanev
chore: remove unused ls-utils.ts file
fa05beb
@ivanstanev
fix: reorganize dockerfile analysis to own module
bf9afd0 
Removes it from the top-level lib/ module as the Dockerfile analysis logic was split across two files. This change unifies it and also exports types from types.ts.
@ivanstanev ivanstanev requested a review from a team as a code owner October 19, 2020 14:53
@ivanstanev ivanstanev self-assigned this Oct 19, 2020
agranado2k
agranado2k reviewed Oct 19, 2020
View reviewed changes
lib/static.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 19, 2020 •
edited by ivanstanev

Expected release notes (by @ivanstanev)

fixes:
reorganize dockerfile analysis to own module (bf9afd0)
remove unused error handling in static scanning (975ed81)

others (will not be included in Semantic-Release notes):
add more deprecation warnings around dependency tree use (f96617d)
remove unused ls-utils.ts file (fa05beb)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

agranado2k
agranado2k approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@agranado2k agranado2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@ivanstanev ivanstanev merged commit 095a3a0 into master Oct 19, 2020
@ivanstanev ivanstanev deleted the fix/code-cleanup branch October 19, 2020 15:24
@snyksec
Copy link

snyksec commented Oct 19, 2020

🎉 This PR is included in version 4.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@honeyp-snyk honeyp-snyk mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agranado2k agranado2k agranado2k approved these changes

Assignees

@ivanstanev ivanstanev

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanstanev @snyksec @agranado2k