Fix/dockerfile instructions #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression with rolling out static scanning. Previously dependencies used to be annotated with the Dockerfile instruction that introduced them. Without this fix we could not properly distinguish between packages installed by the base OS and packages installed by user instructions in the Dockerfile. We were incorrectly representing all packages as coming from the base image.
|
Expected release notes (by @ivanstanev) fixes: others (will not be included in Semantic-Release notes):
|
shaimendel
approved these changes
Nov 2, 2020
|
🎉 This PR is included in version 4.6.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a regression with rolling out static scanning. Previously dependencies used to be annotated with the Dockerfile instruction that introduced them. Without this fix we could not properly distinguish between packages installed by the base OS and packages installed by user instructions in the Dockerfile. We were incorrectly representing all packages as coming from the base image.
What are the relevant tickets?
Jira ticket RUN-1263