Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added filtering history entries with no "created_by" #323

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

agatakrajewska
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

For docker archives we extract auto detected user instructions from the image config. Some of the entries are missing "created_by" so we were throwing an error - this PR is fixing that.

@agatakrajewska agatakrajewska self-assigned this Feb 17, 2021
@agatakrajewska agatakrajewska requested a review from a team as a code owner February 17, 2021 16:30
RotemS
RotemS previously approved these changes Feb 17, 2021
Copy link
Contributor

@agranado2k agranado2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment.

lib/extractor/docker-archive/index.ts Outdated Show resolved Hide resolved
For docker archives we extract auto detected user instructions from the image config. Some of the entries are missing "created_by" so we were throwing an error.
@github-actions
Copy link

github-actions bot commented Feb 17, 2021

Expected release notes (by @agatakrajewska)

fixes:
Added filtering history entries with no "created_by" (503d5c9)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

Copy link
Contributor

@agranado2k agranado2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! 🎉

@agatakrajewska agatakrajewska merged commit 231f1ec into master Feb 17, 2021
@agatakrajewska agatakrajewska deleted the fix/docker-empty-history-entries branch February 17, 2021 17:11
@snyksec
Copy link

snyksec commented Feb 17, 2021

🎉 This PR is included in version 4.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants