-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add openapi spec fact types #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but I don't think I understand your commits 😅
@@ -17,8 +17,10 @@ schemas: | |||
type: string | |||
enum: | |||
- autoDetectedUserInstructions | |||
- binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these missing types also exit in lib/types.ts
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding them to typescript would be misleading because snyk-docker-plugin doesn't actively use them.
🎉 This PR is included in version 6.3.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?