Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix purl generation for container #583

Merged

Conversation

paulrosca-snyk
Copy link
Contributor

@paulrosca-snyk paulrosca-snyk commented Apr 24, 2024

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fixes purl generation for apt and rpm packages. The fix entails:

  • Adding the vendor name as a namespace in PURLs
  • For debian, mapping the version number to a corresponding codename
  • Adding the distro qualifier in PURLs

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@paulrosca-snyk paulrosca-snyk force-pushed the UNIFY-93-package-url-generation-in-snyk-docker-plugin branch 4 times, most recently from f3f9947 to 0edfc17 Compare April 25, 2024 12:45
@paulrosca-snyk paulrosca-snyk marked this pull request as ready for review April 25, 2024 13:07
@paulrosca-snyk paulrosca-snyk requested a review from a team as a code owner April 25, 2024 13:07
@paulrosca-snyk paulrosca-snyk force-pushed the UNIFY-93-package-url-generation-in-snyk-docker-plugin branch from 0edfc17 to 63e1548 Compare April 25, 2024 13:12
Copy link

@mcombuechen mcombuechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulrosca-snyk paulrosca-snyk force-pushed the UNIFY-93-package-url-generation-in-snyk-docker-plugin branch from 63e1548 to 21d5762 Compare April 25, 2024 13:17
@paulrosca-snyk paulrosca-snyk merged commit b24ef00 into main Apr 25, 2024
14 checks passed
@paulrosca-snyk paulrosca-snyk deleted the UNIFY-93-package-url-generation-in-snyk-docker-plugin branch April 25, 2024 13:30
@team-lumos
Copy link
Collaborator

🎉 This PR is included in version 6.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants