This repository has been archived by the owner on Jun 30, 2020. It is now read-only.
feat: add semantic release #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshje
force-pushed
the
feat/semantic-release
branch
2 times, most recently
from
2383756
to
3066d7e
Compare
darscan
reviewed
Aug 14, 2018
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "eslint": "^5.3.0", | ||
| "semantic-release": "^15.9.8" |
There was a problem hiding this comment.
I'd remove this - we're using npx above anyway
There was a problem hiding this comment.
How will the module be available if it isn't installed? Or maybe install it as part of the travis.yml?
There was a problem hiding this comment.
How will the module be available if it isn't installed?
That's sorta the point of npx - running binaries from modules that are not necessarily installed into the project. https://www.npmjs.com/package/npx#description :)
darscan
reviewed
Aug 14, 2018
.travis.yml
Outdated
| node_js: | ||
| - "8" | ||
| after_success: | ||
| npm run semantic-release |
There was a problem hiding this comment.
lol, noooo.. you've gone the other way!
There was a problem hiding this comment.
Let's use npx here, and drop it from our deps
joshje
force-pushed
the
feat/semantic-release
branch
from
6047aa0
to
49d99b4
Compare
darscan
suggested changes
Aug 14, 2018
joshje
force-pushed
the
feat/semantic-release
branch
from
49d99b4
to
d93a4b5
Compare
darscan
approved these changes
Aug 15, 2018
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.