fix: correctly prune within top level deps only #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesPatrickGill
force-pushed
the
fix/over-pruning-for-go-mod-fixed
branch
from
ab00f59
to
4a05260
Compare
JamesPatrickGill
force-pushed
the
fix/over-pruning-for-go-mod-fixed
branch
from
4a05260
to
e8af954
Compare
admons
approved these changes
May 15, 2023
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first implementation of pruning failed to scope pruning to the top level dependencies as the visited variable would be used per loop. This time we scope it by assigning a new visited object per loop if no visited set is passed.