Chore/test and release #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michael-go
reviewed
Aug 6, 2018
.github/CONTRIBUTING.md
Outdated
|
|
||
| ## Code standards | ||
|
|
||
| Ensure that your code adheres to the included `.jshintrc` and `.jscsrc` configs. |
michael-go
reviewed
Aug 6, 2018
.github/CONTRIBUTING.md
Outdated
| - new command line options are generally discouraged unless there's a *really* good reason | ||
| - add tests for newly added code (and try to mirror directory and file structure if possible) | ||
| - spell check | ||
| - PRs will not be code reviewed unless all tests are passing |
There was a problem hiding this comment.
need to also mention our branch naming format
michael-go
approved these changes
Aug 6, 2018
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies, replacing
jscswitheslint, adding contribution agreement.