refactor: reuse the logic from snyk-go-parser #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kicking the build for Travis |
kyegupov
force-pushed
the
refactor/use-parser
branch
from
523096b
to
9695219
Compare
kyegupov
force-pushed
the
refactor/use-parser
branch
from
9695219
to
1e6ab05
Compare
orsagie
reviewed
Apr 15, 2019
|
|
||
| return Promise.all([ | ||
| const result = await Promise.all([ |
There was a problem hiding this comment.
Can you please remove the Promise.all while you are in here?
There was a problem hiding this comment.
It's there for a reason: to perform these tasks in parallel. A small saving, but still.
orsagie
reviewed
Apr 15, 2019
| @@ -17,21 +17,20 @@ | |||
| "test-functional-windows": "tap -R spec --timeout=300 ./test/*.test.ts -g \"^(?!.*symlink)\"", | |||
| "test-system-windows": "tap -R spec --timeout=300 ./test/system/*.test.ts -g \"^(?!.*prometheus)\"", | |||
| "test-windows": "npm run test-functional-windows && npm run test-system-windows", | |||
| "semantic-release": "semantic-release", | |||
There was a problem hiding this comment.
why is semantic release removed?
There was a problem hiding this comment.
The proper style, as taught by @lili2311 , is to use "npx semantic-release" in the .travis.yml, which automatically uses the latest and the greatest version.
orsagie
approved these changes
Apr 15, 2019
|
🎉 This PR is included in version 1.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supersedes #36
Since the manifest parsing logic has now been separated into snyk-go-parser, it makes sense for the plugin to re-use that.
Drive-by: robustify tests, clean up the build script.
How should this be manually tested?
Scanning Go projects via CLI.