Refactor: Rename variables to inputs [CFG-1500]

[ofekatr]

What this does

• Refactors types for storing input values, local values, and TF variables in the terraform package.
  This change helps clarify the contents of different variable-related structs and maps in our current parser's flow.
• Renames several functions and types with the variable term, to use the term input instead.
  This change helps gain better distinguishment between inputs and locals in the code, as both are considered variables in Terraform.

More information

• CFG-1500

[ipapast]

I think the general refactor is good, I'm only concerned about the word inputs as we are completely removing the variables word here. What do you think of inputVariables instead? So someone that looks at this the first time understands what it is and it still aligned with the Terraform vocabulary.

I think It's the middle ground. What do you think? @ofekatr @YairZ101

[YairZ101]

I think the general refactor is good, I'm only concerned about the word inputs as we are completely removing the variables word here. What do you think of inputVariables instead? So someone that looks at this the first time understands what it is and it still aligned with the Terraform vocabulary.

I think It's the middle ground. What do you think? @ofekatr @YairZ101

I've renamed all the places we used inputs and changed them to inputVariables as you suggested.
Can you please give it a 2nd look to check I didn't miss anything?

[ipapast]

I think the general refactor is good, I'm only concerned about the word inputs as we are completely removing the variables word here. What do you think of inputVariables instead? So someone that looks at this the first time understands what it is and it still aligned with the Terraform vocabulary.
I think It's the middle ground. What do you think? @ofekatr @YairZ101

I've renamed all the places we used inputs and changed them to inputVariables as you suggested. Can you please give it a 2nd look to check I didn't miss anything?

it looks okay to me, I will trust your editor for renaming more than my eyes :) thank you!

[ipapast]

🚢