feat: Use the latest, custom Terraform parser #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
snyk
CLI uses the version of the Terraform parser implemented by theterraform
package in this library. TheParseHCL2
function, exported by this library and used bysnyk-iac-rules
, still uses plainhcl2json
.Because of this difference, users of
snyk-iac-rules
and users ofsnyk
don't have a consistent developer experience. A user writing a custom rule, and testing it viasnyk-iac-rules
, might be unable to run that rule insnyk
. An example of this incompatibility is the handling of thejsonencode
function in Terraform code.Given this input file:
snyk-iac-rules
, which is still based onhcl2json
, produces this:The parser in the
snyk
CLI, based on theterraform
package, produces this:This PR fixes this incompatibility by using the same parser everywhere, consistently. Moreover, this PR stacks on top of #31, which should be merged first.