Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade GitHub actions and fix release-it installation #32

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: Upgrade GitHub actions and fix release-it installation #32

merged 1 commit into from
Jan 20, 2023

Conversation

francescomari
Copy link
Contributor

Fixes the release workflow:

  • Some GitHub actions are deprecated because they run on Node 12.
  • release-it is unable to find @release-it/conventional-changelog when installed globally.

@francescomari francescomari requested a review from a team as a code owner January 20, 2023 09:34
@francescomari francescomari merged commit fc4e3e3 into main Jan 20, 2023
@francescomari francescomari deleted the fix/release-workflow branch January 20, 2023 09:36
craigfurman
craigfurman reviewed Jan 20, 2023
View reviewed changes
Copy link

@craigfurman craigfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is already merged, but I was going to leave an approval for posterity. It's not actually possible to do this, which is a shame, but thanks for fixing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigfurman craigfurman craigfurman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@francescomari @craigfurman