Feat: Added inputs variables dereferencing support [CFG-1501] #7
Conversation
YairZ101
requested review from
karniwl and
ipapast
and removed request for
karniwl
|
|
YairZ101
force-pushed
the
feat/add-inputs-vars-deref
branch
4 times, most recently
from
0c0bd46
to
1cd7ce1
Compare
ofekatr
changed the title
ofekatr
force-pushed
the
feat/add-inputs-vars-deref
branch
3 times, most recently
from
2fe3299
to
0902b59
Compare
ofekatr
changed the title
YairZ101
force-pushed
the
feat/add-inputs-vars-deref
branch
5 times, most recently
from
575c1dd
to
5793283
Compare
|
@ipapast and @teodora-sandu can you please do a quick re-review to the changes I did following your feedback? :) |
YairZ101
force-pushed
the
feat/add-inputs-vars-deref
branch
2 times, most recently
from
67ffb7a
to
2914910
Compare
YairZ101
force-pushed
the
feat/add-inputs-vars-deref
branch
from
2914910
to
97b27df
Compare
| } | ||
|
|
||
| type VariableMap map[string]cty.Value | ||
| func extractFromTfFile(file *hcl.File) (VariableMap, hcl.Diagnostics) { |
There was a problem hiding this comment.
nit: Would it be nicer to name this extractVariableBlocks or something like this?
There was a problem hiding this comment.
I think that extractVariableBlocks sounds more abstract but I personally think that extractFromTfFile makes it more explicit what this function does and what it's being used for.
| @@ -531,48 +532,115 @@ block "label_one" { | |||
| } | |||
|
|
|||
| func TestExtractVariablesSuccess(t *testing.T) { | |||
| type TestInput struct { | |||
| fileName string | |||
There was a problem hiding this comment.
nit: Do we need the fileName here? It was defaulting to "test" before and the simpler this test table is the better
There was a problem hiding this comment.
We added it to prepare for the next ticket where we will have different logic for .tf and .tfvars files.
What this does
Adds supporting reading variable values in Terraform (.tf) files.
This is done to help on our vision to create better TF support for our product and find more issues that might have been ignored so far because they would be coming from variable values.
This PR is to support input variables, with or without default values.
Background context
In the Decision Document, we decided to create a new library in Go where the implementation for this would live.
We already have played a spike on how this could look like.
We plan to build a parser that can deal with (end goal):
As part of this ticket, we will only be adding support for input variables (and defaults).
Additional information