fix: use classifier in package name #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrunley-snyk
approved these changes
Jun 9, 2021
dtrunley-snyk
requested review from
dtrunley-snyk
and removed request for
dtrunley-snyk
gitphill
force-pushed
the
fix/use-classifier-in-pkg-name
branch
from
5058272
to
4082c5d
Compare
When two dependencies with the same groupId and artifiactId appear in the dep tree, but they have a different classifier we should treat them as different nodes in the tree. At the moment we overwrite these nodes, which can lead to incorrect results form snyk test. Adding new test for duplicate dep with classifier. Fixing parse-mvn to correctly identify each part of a dependency.
gitphill
force-pushed
the
fix/use-classifier-in-pkg-name
branch
from
4082c5d
to
77bca8e
Compare
|
🎉 This PR is included in version 2.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When two dependencies with the same groupId and artifiactId appear in the dep tree, but they have a different classifier we should treat them as different nodes in the tree. At the moment we overwrite these nodes, which can lead to incorrect results form snyk test.