Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish ts declaration files #122

Closed
wants to merge 1 commit into from

Conversation

merisbahti
Copy link

@merisbahti merisbahti commented Apr 28, 2022

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Configures tsc to build the d.ts artifacts for publishing.

Where should the reviewer start?

tsconfig.json

How should this be manually tested?

Check so that everything looks fine in ./dist after running npm run build

Any background context you want to provide?

Nope

What are the relevant tickets?

None that I know of

Screenshots

image

Additional questions

Any reason this line was commented out?

@merisbahti merisbahti requested a review from a team as a code owner April 28, 2022 12:30
@merisbahti merisbahti requested review from jk05 and Jdunsby April 28, 2022 12:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@gitphill gitphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason why this shouldn't be on - thanks!

@gitphill
Copy link
Contributor

gitphill commented Apr 28, 2022

can you sign the CLA @merisbahti - then I think we can merge

@gitphill gitphill mentioned this pull request Apr 28, 2022
3 tasks
@gitphill
Copy link
Contributor

Ah don't think our CircleCI build pipeline is setup to run PRs from forked repos - I've recreated here #123

@gitphill gitphill closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants